Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): upgrade to [email protected]. (closes #393) #429

Merged
merged 25 commits into from
Mar 26, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Mar 16, 2017

Description

#393
Starting the PR (will set its description later)

What's included?

  • chore(): upgrade to [email protected] (and dependencies)
  • feat(): replace template with ng-template
  • feat(): replace OpaqueToken with InjectionToken
  • feat(): import BrowserAnimationsModule where needed
  • chore(flex-layout): update to rc.1 for [email protected] support
  • feat(): remove Renderer infavor of Renderer2
  • feat(toggle): support for ng4
  • feat(fade): support for ng4

Test Steps

  • do this
  • then this
  • finally this

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

@emoralesb05 emoralesb05 added this to the Beta 3 milestone Mar 16, 2017
@emoralesb05 emoralesb05 changed the title feat(): upgrade to [email protected] feat(): upgrade to [email protected]. (closes #393) Mar 16, 2017
@joshwiens
Copy link
Contributor

joshwiens commented Mar 22, 2017

On the off chance you missed this as opposed to just haven't gotten to it yet..

src/platform/core/common/animations fade && toggle are still using renderer.setElementStyle

Update: evidently we aren't getting programatic access to animations in 4.0.0 and have to wait until 4.1.0-beta and then use AnimationBuilder

@emoralesb05
Copy link
Contributor Author

emoralesb05 commented Mar 22, 2017

Yep! 😄 , i was waiting on this to see if we can still use Renderer for now or access directly @angular/animations/browser pre 4.1.0-beta as stated in angular/angular#15294 (comment). If Renderer will still be there until 4.1.0, then we can just keep using it for now.

@mmoravcik
Copy link

Any idea when is this going to be released? Great framework BTW

@joshwiens
Copy link
Contributor

@mmoravcik - It's available in the nightly

@mmoravcik
Copy link

@d3viant0ne thanks but still getting the following when running ng build prod with CLI

ERROR in _gendir/node_modules/@covalent/core/data-table/data-table.component.ngfactory.ts     (1,1): Property '_selectable' is private and only accessible within class 'TdDataTableComponent'.

/node_modules/@covalent/core/data-table/data-table.component.html (14,5): Property '_data' is private and only accessible within class 'TdDataTableComponent'.

$$_gendir/node_modules/@covalent/core/data-table/data-table.component.ngfactory.ts (1,1): Property '_selectable' is private and only accessible within class 'TdDataTableComponent'.

@joshwiens
Copy link
Contributor

Already reported in #471 which has an open pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants