-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug? Deprecation of the .forRoot() #473
Comments
This could be because of covalent being compiled using the @angular/compiler-cli v2.4.x |
why are u trying to compile angular 4.x.x with compiler cli 2.4.x? For angular 4.x.x you need compiler cli 4.x.x |
Btw, if you are using the current release version, there is no support for angular 4,x,x |
@jotatoledo I am aware that this project doesn't work with angular 4 yet. However as I mentioned, I am using the nightly version which has been patched for Angular 4 support (#429) despite being compiled using the 2.4.x compiler. Adding some more details to add context I was able to get this working in JIT mode with the .forRoot() method which failed in the AOT mode. I was able to compile using AOT after removal of the .forRoot method but then it started complaining that some service wasn't provided The background is that the forRoot method during bootstrap was deprecated to be removed and every service that needed to be a singleton service was provided as a singleton service without the need for the forRoot method. So I found it a little confusing when it says there is no provider found. (Check #389) So this is basically a ticket to say that I am not sure if there is a bug or not, but seems like something is not the way it should be. |
@asaph26 my bad, missed the part on ur comment where u mentioned the use of the nighly version |
Which services werent provided in the error? We stopped using forRoot in the docs a while back and works fine. So im trying to see if we missed something. |
Found the issue with for |
This is resolved now. Thanks @emoralesb05 |
While initialising the module using .forRoot() using the latest CLI in AOT it fails with
ERROR in Error encountered resolving symbol values statically. Calling function 'CovalentCoreModule', function calls are not supported.
Given that this will be deprecated in the upcoming beta.3, trying to use the nightly version with AOT causes the providers to not be initialised.
Note:
The text was updated successfully, but these errors were encountered: