Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on ng build --prod on ng4 #460

Closed
pascalwhoop opened this issue Mar 29, 2017 · 4 comments
Closed

Errors on ng build --prod on ng4 #460

pascalwhoop opened this issue Mar 29, 2017 · 4 comments

Comments

@pascalwhoop
Copy link

pascalwhoop commented Mar 29, 2017

This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?

bug

Bug Report

running ng build --prod with covalent as dependency gives many errors on build

ERROR in ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (35,10): Property 'hideContentOverflow' does not exist on type 'TdExpansionPanelComponent'.
ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (35,10): Property 'hideContentOverflow' does not exist on type 'TdExpansionPanelComponent'.
ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (36,10): Property 'hideContentOverflow' does not exist on type 'TdExpansionPanelComponent'.
ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (36,10): Property 'hideContentOverflow' does not exist on type 'TdExpansionPanelComponent'.
ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (42,10): Property 'hideSummaryOverflow' does not exist on type 'TdExpansionPanelComponent'.
ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (42,10): Property 'hideSummaryOverflow' does not exist on type 'TdExpansionPanelComponent'.
ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (43,10): Property 'hideSummaryOverflow' does not exist on type 'TdExpansionPanelComponent'.
ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (43,10): Property 'hideSummaryOverflow' does not exist on type 'TdExpansionPanelComponent'.
ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (33,10): Property 'hideContentOverflow' does not exist on type 'TdExpansionPanelComponent'.
ng:///Users/pbr/Documents/Code/OC/API-Projekt/Steak/SteakWeb/node_modules/@covalent/core/expansion-panel/expansion-panel.component.html (40,10): Property 'hideSummaryOverflow' does not exist on type 'TdExpansionPanelComponent'.

My Modules:

//app.module.ts
@NgModule({
    declarations: [
        AppComponent
    ],
    imports: [
        CoreModule,
        SharedModule,
        AppRoutingModule,
        ClientModule,
        LoginModule,
        AjaxVisualFeedbackModule
    ],
    providers: [{provide: BrowserXhr, useExisting: CustomBrowserXhr}],
    bootstrap: [AppComponent]
})
export class AppModule {
}

//lazy loaded client orders module
@NgModule({
    imports: [
        CovalentCoreModule,
        SharedModule,
        RouterModule.forChild([{path: '', component: OrdersPageComponent}])
    ],
    declarations: [OrdersPageComponent, OrdersSummaryCardComponent, OrdersHistoryTableComponent]
})
export class OrdersModule {
}

What is the expected behavior?

fewer or no errors

Which version of Angular and Material, and which browser and OS does this issue affect?

  "dependencies": {
    "@angular/animations": "^4.0.0",
    "@angular/common": "^4.0.0",
    "@angular/compiler": "^4.0.0",
    "@angular/core": "^4.0.0",
    "@angular/flex-layout": "^2.0.0-rc.1",
    "@angular/forms": "^4.0.0",
    "@angular/http": "^4.0.0",
    "@angular/material": "latest",
    "@angular/platform-browser": "^4.0.0",
    "@angular/platform-browser-dynamic": "^4.0.0",
    "@angular/router": "^4.0.0",
    "@covalent/core": "^1.0.0-beta.2-1",
    "core-js": "^2.4.1",
    "hammerjs": "^2.0.8",
    "lodash": "^4.17.4",
    "rxjs": "^5.2.0",
    "zone.js": "^0.8.5"
@asaph26
Copy link
Contributor

asaph26 commented Mar 29, 2017

I don't think the project is ready for Angular 4 with the version of covalent you are running.

Angular 4 support was added as part #429 and will be available through beta3

@emoralesb05
Copy link
Contributor

emoralesb05 commented Mar 29, 2017

This was already fixed in #448 also, will be available in beta.3 like @asaph26 said

@dapriett
Copy link

dapriett commented Apr 4, 2017

Hey @emoralesb05 - do you guys have an ETA of beta.3?

@emoralesb05
Copy link
Contributor

We were waiting on material beta.3 to release all together, but since ng-conf is this week, we might release beta.3 asap and just do a beta.3-1 when material releases beta.3.

We are currently debating that since we are pretty much done with our beta.3 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants