Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DisplayMediaCard, PosterCard): add extra #1131

Merged
merged 7 commits into from
Jun 4, 2024
Merged

feat(DisplayMediaCard, PosterCard): add extra #1131

merged 7 commits into from
Jun 4, 2024

Conversation

yceballost
Copy link
Contributor

@yceballost yceballost commented May 28, 2024 •
edited
Loading

issue: WEB-1886

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Size stats

master this branch diff
Total JS 10.7 MB 10.7 MB +87 B
JS without icons 1.94 MB 1.94 MB +87 B
Lib overhead 53.8 kB 53.8 kB 0 B
Lib overhead (gzip) 14.4 kB 14.4 kB 0 B

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-d9mq4swl0-flows-projects-65bb050e.vercel.app

Built with commit b600155.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Screenshot tests report

✔️ All passing

@yceballost yceballost marked this pull request as ready for review May 28, 2024 11:31
@yceballost
Copy link
Contributor Author

Screenshot tests report

❌ navigation-bar-ssr-acceptance-test-tsx-ssr-main-navigation-bar / undefined
❌ navigation-bar-ssr-acceptance-test-tsx-ssr-main-navigation-bar-large / undefined

This issue depends on #1129 (comment)

@yceballost yceballost changed the title feat(DisplayMediaCard, PosterCard): add extra to displayMedia and Poster card feat(DisplayMediaCard, PosterCard): add extra May 28, 2024
@marcoskolodny
Copy link
Collaborator

Screenshot tests report
❌ navigation-bar-ssr-acceptance-test-tsx-ssr-main-navigation-bar / undefined
❌ navigation-bar-ssr-acceptance-test-tsx-ssr-main-navigation-bar-large / undefined

This issue depends on #1129 (comment)

I've fixed this issue in #1127. You can pull changes from master into this PR :)

marcoskolodny
marcoskolodny reviewed May 28, 2024
View reviewed changes
src/__stories__/poster-card-story.tsx
@@ -64,6 +66,7 @@ export const Default: StoryComponent<PosterCardArgs> = ({
title,
subtitle,
description,
withExtra,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have half of our stories using withExtra and the other half extra. Which one should we use?

Copy link
Contributor Author

@yceballost yceballost May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we have some "icon" instead of "withIcon" (in tag story for example)

perhaps it is better to create a task to solve these "purity details" across all stories.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created an issue for this: https://jira.tid.es/browse/WEB-1891

pladaria
pladaria reviewed May 30, 2024
View reviewed changes
src/card.tsx
@@ -1593,6 +1595,7 @@ export const PosterCard = React.forwardRef<HTMLDivElement, PosterCardProps>(
</Text2>
</div>
)}
{extra}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is expected to not have any spacings between the extra an the other elements.

Please add some screenshot tests to verify

Copy link
Contributor Author

@yceballost yceballost May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the extra props let this spacing to be the responsibility of the designer

I didn't include screenshots because we don't have screenshots in displayDataCard for extra. But I will do it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@yceballost yceballost requested a review from pladaria May 30, 2024 12:49
@atabel atabel added this pull request to the merge queue Jun 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2024
@marcoskolodny marcoskolodny enabled auto-merge June 4, 2024 15:27
@marcoskolodny marcoskolodny added this pull request to the merge queue Jun 4, 2024
Merged via the queue into master with commit 501cf73 Jun 4, 2024
11 checks passed
@marcoskolodny marcoskolodny deleted the iceballos-displayMedia-slot branch June 4, 2024 15:42
tuentisre pushed a commit that referenced this pull request Jun 19, 2024
@semantic-release-bot
chore(release): 15.11.0 [skip ci]
e7af740 
# [15.11.0](v15.10.0...v15.11.0) (2024-06-19)

### Bug Fixes

* **ButtonLayout:** add bleed when using only link ([#1150](#1150)) ([554f98a](554f98a))
* **Counter:** add aria-live to value ([#1146](#1146)) ([3e2e09b](3e2e09b))
* **Header:** bleed not working in o2-new skin ([#1137](#1137)) ([00fb632](00fb632))
* **MainNavigationBar:** remove logo space in mobile when no sections are given ([#1149](#1149)) ([e4c03a0](e4c03a0))
* **Select:** set text color in native version ([#1141](#1141)) ([eedf265](eedf265))
* **Spinner:** use controlActivatedInverse token as default when used inside inverse variant ([#1133](#1133)) ([38a192d](38a192d))

### Features

* **Cards:** improve accessibility ([#1139](#1139)) ([dde9cc5](dde9cc5))
* **Chip:** allow using badge in selectable chips ([#1134](#1134)) ([9ecda7c](9ecda7c))
* **Circle:** custom background support ([#1136](#1136)) ([bedeaa4](bedeaa4))
* **CoverHero:** new component ([#1144](#1144)) ([a655e6e](a655e6e))
* **DisplayMediaCard, PosterCard:** add extra ([#1131](#1131)) ([501cf73](501cf73))
* **EmptyState:** allow using only ButtonLink as action ([#1140](#1140)) ([d73c219](d73c219))
* **HighlightedCard:** support for alt for image ([#1135](#1135)) ([c9ba728](c9ba728))
* **Image:** Custom fallback icon in Vivo New ([#1145](#1145)) ([ec600fe](ec600fe))
* **Switch:** Improve animation ([#1142](#1142)) ([8162eed](8162eed))
* **Table:** new component ([#1129](#1129)) ([328e013](328e013))
* **Timer:** create component ([#1130](#1130)) ([0b3253e](0b3253e))
* **Touchable:** newTab support in to links ([#1143](#1143)) ([eff07e3](eff07e3))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 15.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aweell aweell linked an issue Jun 19, 2024 that may be closed by this pull request
Slot in DisplayMedia & Poster card Telefonica/mistica-design#1661
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoskolodny marcoskolodny marcoskolodny approved these changes

@atabel atabel atabel approved these changes

@pladaria pladaria pladaria approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slot in DisplayMedia & Poster card
5 participants
@yceballost @marcoskolodny @tuentisre @pladaria @atabel