fix(IconButton): add borderRadius to button's overlay #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
marcoskolodny
commented
May 22, 2024
| @@ -417,6 +417,7 @@ export const overlay = style({ | |||
| width: '100%', | |||
| height: '100%', | |||
| backgroundColor: 'transparent', | |||
| borderRadius: '50%', | |||
There was a problem hiding this comment.
I have no idea why the overlay was rounded in most cases, but not in Popover (only in iOS).
This fixes the issue
|
Accessibility report ℹ️ You can run this locally by executing |
marcoskolodny
commented
May 22, 2024
| @@ -569,7 +569,7 @@ export const BaseTooltip: React.FC<BaseTooltipProps> = ({ | |||
|
|
|||
| {onClose && ( | |||
| <div className={styles.closeButtonIcon}> | |||
| <InternalIconButton | |||
| <IconButton | |||
There was a problem hiding this comment.
Not related. We can use IconButton here, we are not using hasOverlay/isOverMedia in here
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit c6510ce. |
atabel
approved these changes
May 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🎉 This PR is included in version 15.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Link