Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube kiosk (Trending Music) addition Issue #8801 NewPipe (Partial Solution) #955

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

CaptSzat
Copy link

@CaptSzat CaptSzat commented Oct 26, 2022

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Added Youtube Muisc Trending Kiosk but unable to get a link to the YouTube music trending page so the Youtube Trending Music kiosk diusplays Trending feed until a fix can be found.

NewPipe PR: TeamNewPipe/NewPipe#9200

@CaptSzat CaptSzat changed the title Youtube kiosk (Trending Music) addition Issue #8801 NewPipe (Partitial Solution) Youtube kiosk (Trending Music) addition Issue #8801 NewPipe (Partial Solution) Oct 26, 2022
Comment on lines +62 to +73
assertTrue(LinkHandlerFactory.acceptUrl("https://www.youtube.com/feed/trending/music"));
assertTrue(LinkHandlerFactory.acceptUrl("https://www.youtube.com/feed/trending/music/?adsf=fjaj#fhe"));
assertTrue(LinkHandlerFactory.acceptUrl("http://www.youtube.com/feed/trending/music/"));
assertTrue(LinkHandlerFactory.acceptUrl("www.youtube.com/feed/trending/music"));
assertTrue(LinkHandlerFactory.acceptUrl("youtube.com/feed/trending/music"));
assertTrue(LinkHandlerFactory.acceptUrl("youtube.com/feed/trending/music/?akdsakjf=dfije&kfj=dkjak"));
assertTrue(LinkHandlerFactory.acceptUrl("https://youtube.com/feed/trending/music"));
assertTrue(LinkHandlerFactory.acceptUrl("m.youtube.com/feed/trending/music"));

assertTrue(LinkHandlerFactory.acceptUrl("https://www.invidio.us/feed/trending/music"));
assertTrue(LinkHandlerFactory.acceptUrl("https://invidio.us/feed/trending/music"));
assertTrue(LinkHandlerFactory.acceptUrl("invidio.us/feed/trending/music"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these links actually work, not sure if we should be doing these. They all use the /feed/trending path.

// @formatter:off
final byte[] body = JsonWriter.string(prepareDesktopJsonBuilder(getExtractorLocalization(),
getExtractorContentCountry())
.value("browseId", "MUtrending")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried looking for this browseId everywhere, on youtube.com and music.youtube.com (There's no trending page at all).

What I found out is that the official client uses a browseId of FEtrending with the params as 4gINGgt5dG1hX2NoYXJ0cw%3D%3D, which is URL and base64 encoded protobuf.

image

The protobuf decoded looks like this:
image

I think we should change this to follow the official client.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

music: '4gINGgt5dG1hX2NoYXJ0cw%3D%3D',
gaming: '4gIcGhpnYW1pbmdfY29ycHVzX21vc3RfcG9wdWxhcg%3D%3D',
movies: '4gIKGgh0cmFpbGVycw%3D%3D'

@Stypox
Copy link
Member

Stypox commented Oct 27, 2022

@FireMasterK could you take care of having this PR merged? You know extractor/YouTube code better than me ;-). Also look at TeamNewPipe/NewPipe#8801 (comment).

@CaptSzat try to change the request parameters as @FireMasterK said :-)

@supersu-man

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants