Youtube kiosk (Trending Music) addition Issue #8801 (Partial Solution) #9200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Stypox
requested changes
Oct 27, 2022
| dependencySubstitution { | ||
| substitute module('com.github.TeamNewPipe:NewPipeExtractor') using project(':extractor') | ||
| } | ||
| } |
There was a problem hiding this comment.
Please undo the changes in this file, they are not meant to be committed! ;-)
Instead you should change the NewPipeExtractor line in app/build.gradle (699b4086398f1e0f412e178532e85c7a23fadf83 is the last commit in your extractor PR):
implementation 'com.github.CaptSzat:NewPipeExtractor:699b4086398f1e0f412e178532e85c7a23fadf83'
| @@ -113,6 +113,7 @@ public class MainActivity extends AppCompatActivity { | |||
| private static final int ITEM_ID_BOOKMARKS = -3; | |||
| private static final int ITEM_ID_DOWNLOADS = -4; | |||
| private static final int ITEM_ID_HISTORY = -5; | |||
| private static final int ITEM_ID_TRENDING_MUSIC = -6; | |||
There was a problem hiding this comment.
I don't think you need this, please revert the changes in this file ;-)
SameenAhnaf
added
feature request
|
Closing as there has not been any activity after this PR was opened. Feel free to reopen after TeamNewPipe/NewPipeExtractor#955 is merged. This PR is really small anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
I have added the Youtube Music Trending Kiosk. However I was unable to get a link to the YouTube music trending page so the Youtube Trending Music kiosk diusplays Trending feed until a fix can be found.
Fixes the following issue(s)
NewPipeExtractor: TeamNewPipe/NewPipeExtractor#955
Due diligence