Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a YouTube music trending Kiosk #8801

Open
5 tasks done
B0pol opened this issue Aug 15, 2022 · 7 comments
Open
5 tasks done

Make a YouTube music trending Kiosk #8801

B0pol opened this issue Aug 15, 2022 · 7 comments
Labels
feature request Issue is related to a feature in the app youtube Service, https://www.youtube.com/

Comments

@B0pol
Copy link
Member

B0pol commented Aug 15, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Make YouTube Music kiosk. Just like #1805 is about other trending kiosks, it would be nice to have one for YouTube music trending kiosk

Why do you want this feature?

To discover new music, see what’s the most popular in a given country (because it’s country-specific)

Additional information

No response

@B0pol B0pol added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Aug 15, 2022
@triallax triallax added youtube Service, https://www.youtube.com/ and removed needs triage Issue is not yet ready for PR authors to take up labels Aug 16, 2022
@CaptSzat
Copy link

Hello, I am a student from the ANU and am hoping I can create a PR for this issue. Could you assign this issue to me! thank you :)

@opusforlife2
Copy link
Collaborator

@CaptSzat How many students in your class/course are here? Our repo is practically flooded with you guys. xD

@CaptSzat
Copy link

@opusforlife2
There is like 200ish people I want to say in the course. You can see the assignment if your intrested https://comp.anu.edu.au/courses/comp2120/assignments/group-assignment3/
Thanks for putting me on the issue.

@CaptSzat
Copy link

@opusforlife2 is there any more additional documentation on kiosks. I assumed that to solve this issue I would just need to initiate a new kiosk which then accpeted a filtered feed. But that doesn't seem to be the case, as kiosks haven't been implimented the way the graphic in issue #1805 showed.

@Stypox
Copy link
Member

Stypox commented Oct 25, 2022

@CaptSzat here is some guidance:

  • The kiosk code you need to change is not in this repository but rather in NewPipeExtractor
  • You should create a public class YoutubeMusicTrendingExtractor extends KioskExtractor<StreamInfoItem> { and implement the data extraction there (see for example the already-implemented YoutubeTrendingExtractor)
  • In the YoutubeService's getKioskList you should return two kiosks instead of only one (see for example how Bandcamp is able to provide multiple kiosks)
  • Make sure the data extractor works well and the tests you wrote for your newly implemented KioskExtractor pass (see e.g. YoutubeTrendingKioskInfoTest)
  • You can now switch over to the NewPipe repository and tell app/build.gradle to use your NewPipeExtractor version
  • Make sure the trending screen you added works properly in the app and use a Material icon related to music to show for the kiosk entry

@CaptSzat
Copy link

CaptSzat commented Oct 26, 2022

@Stypox Thank you for the help! I've managed to setup everything to get the Trending Muisc kiosk working. The only issue now is that there is no clear way on the YT site to get the trending music. For example to get the trending feed you just use /feed/trending but for music unfortunately I have been unable to find a similar link. I have tried /feed/music, /feed/trending/music and /music. All of which either provide just the trending page which is the fall back if you do /feed or throw errors in the project becasue the music page is not deisgned to be parsed. I think that the solution to getting the trenidng music feed is prehaps above my current understanding of the project. If its fine with maintainers (@opusforlife2 ) I might do a PR with a partial solution for this issue. Then if someone else is able to find a way to access the music trending feed the two solutions can be combined.

The current solution I have come up with adds the YoutubeMusicTrendingExtractor, YouTubeMusicTrendingLinkHandlerFactory. It also modifies the YoutubeService file. I also made sure to add an icon in the NewPipe files.

@opusforlife2
Copy link
Collaborator

Lol, I'm not a maintainer. I'm just customer care. If you wanna get your PRs approved you have to talk to my boss Stypox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app youtube Service, https://www.youtube.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants