Clicking on title should open video details

[budde25]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Clicking the video title on the Main Player and Background Player opens the details page for that video.

Fixes the following issue(s)

• fixes Click on title in background player should open video details #3700

Testing apk

app-debug.zip

Agreement

• I carefully read the contribution guidelines and agree to them.

[B0pol]

It doesn't work on Android TV, I believe it's because you have removed android:focusable=true

And please next time compress the apk with a zip file, don't just rename the file extension. 1) compression means less to download 2) makes more sense

[budde25]

@B0pol

It doesn't work on Android TV, I believe it's because you have removed android:focusable=true

I added focus back in for the children so that it should be selectable from from a device without a touchscreen. I also realized I forgot to make the changes to the large-land.xml which might be the reason too. I don't have an android TV to test on but plugging a keyboard into my phone did work. I've updated the testing apk.

And please next time compress the apk with a zip file, don't just rename the file extension. 1) compression means less to download 2) makes more sense

Thanks for the tip! For some reason I was under the impression that .apk files where already compressed. I will make sure to do that going forward!

[Stypox]

_{Another tip: use closing keywords when pointing out a fixed issue, so that GitHub closes it automatically on merge. I edited the description.}

[hunkjazz]

This is a good PR, but needs enhancement on:

• main player;
• popup player.

Main Player

When clicking on title, while using the main player, this happens:

1. main player closes;
2. details page is shown.

I don't think this is quite a good UX.
Instead, this should be the flow:

• switch to popup player;
  • if phone is in portrait:
    • fit popup's width to phone's;
    • move popup to the top of the screen.
• details page is shown underneath popup;
• user expands popup (back to main player);
• NewPipe restores and saves popup width and position back what it was before user clicked to see details;
• page that was active before replacement by details page is restored.

Popup Player

I think it's important to add a details icon under expand icon. In this
way popups opened by other apps can redirect users to further details,
for example.

This same icon can be hidden, if popup gets too small.

This icon should be hidden, when clicking to see details in
main player (if former enhancement suggestion is accepted).

[MD77MD]

I think this should be looked at after the unified player feature

[MD77MD]

this has suddenly became less useful after unified player or am I missing something?

[TobiGr]

@MD77MD Correct, turning the screen opens the details now.
@budde25 Thank you for your contribution!

[TobiGr]

Oh, my bad. This is still a good feature.
@budde25 Please rebase your PR.

[MD77MD]

@TobiGr sorry but I don't get it. when could you use this? the title does not show up in pop mode. in portrait mode, info is already there. that's the same for background mode. the only time you can click the title is in landscape mode, in which pressing the back button would give you the same thing.

However, a new implementation of this feature would be to add an info button in the pop-player. the button -when pressed- can take us back (reopen) the video info. now that's useful.

p.s: another implementation would be in notification. when pressing on the video title the video info would show up instead of play queue. which I would rather not but mentioned it for argument sake.

[opusforlife2]

The lad has a point. Even for landscape mode, there is now the ability to swipe up on the fullscreen button to view video details (thanks, avently!) . And if system rotation is unlocked, then the user can just turn the phone to see them.

[MD77MD]

Even for landscape mode, there is now the ability to swipe up on the fullscreen button to view video details (thanks, avently!) 

@opusforlife2 please tell me how to enable this😰! ... are you referring to what happens when you press back button in landscape mode... or do you mean video info would show up on top of video like what happens when you press on playlists button, I wish you mean it's the second one 😅. that would just be awesome.

[justanidea]

@MD77MD Watch the end of #4121
#4121 (comment)

[opusforlife2]

@justanidea You could always link directly to the relevant comment.

@MD77MD #4121 (comment)

[justanidea]

Ok i didnt think my github client actually could, but it does
TY

[MD77MD]

@justandidea @opusforlife2
thank you guys

[hunkjazz]

@MD77MD @opusforlife2

Would you happen to have a link to download a working apk with the unified player?

[opusforlife2]

@hunkjazz https://github.com/TeamNewPipe/NewPipe/projects/17#card-42918515

[Stypox]

Yeah, I don't see why this should be merged, now that we have unified ui @TobiGr

[budde25]

@Stypox Yeah that makes sense to me

[triallax]

@budde25 I'm closing this PR since it seems like it's not necessary anymore, but please make comment if I turn out to be wrong so I can re-open it. Thanks!