add «Always expand description» in appearance settings, closes #1113

[B0pol]

• I carefully read the contribution guidelines and agree to them.

Closes #1113
I added a switch in appearance settings for that, and the default value is false (stays as it's now).

[Jethrobsn]

Can you guys make it compatible with android 4.1.2? Please???😢😢😢

[B0pol]

I just added a settings to automatically launch or not toggleTitleAndDescription function. So it will work on all devices since the toggleTitleAndDescription function already works on all devices.

But if you wanna use NewPipe with android 4.1, look for NewPipe legacy

[Jethrobsn]

Thank you so much!!! I love the app!!! More power to you guys...👍👍👍

[Stypox]

@B0pol could you provide a test apk? Code looks good to me ;-)

[B0pol]

autoExpandDescription.zip
Here you go @Stypox

[Stypox]

The apk works correctly. Just a small thing ;-)

[Stypox]

Thank you :-D

[TobiGr]

I am not sure if this setting is really needed. That feature request is 2 years old and received only 3 votes.

[B0pol]

Well, then remove from the projects issues you think unecessary, and also don't add the pr in milestones @TobiGr.

[opusforlife2]

Why not? More power to the user.

[justanidea]

Im okey with this project too.

[Stypox]

@B0pol sorry, my bad for adding it to Projects, apparently the feature is requested by a small number of people. Since this was added to the milestone I thought it was going to be merged, but I agree with @TobiGr
@opusforlife2 @gillhash it is not a good idea to have too many options, because then they can't be found anymore and the user can't come across them, therefore losing their purpose.
@TobiGr @B0pol we could add an "Advanced settings" entry in the main settings screen, so that we can add as many small and not-much-requested settings as we want without creating problems. What do you think?

[wb9688]

@Stypox: I think that'd be OK, but only for really small things (i.e. low maintanance burden). I'm not sure if "Advanced settings" would be the correct name for it though.

[B0pol]

we could add an "Advanced settings" entry in the main settings screen, so that we can add as many small and not-much-requested settings as we want without creating problems. What do you think?

I don't think it's a good idea. Currently, settings are ok~ organized (why is main page content in appearance), so if you see the category, you'll know what it's about.

If you put advanced settings, you will throw settings in it and it will be shambolic

[Stypox]

Or we could add a switch to enable advanced settings ("fine-tuning settings"?), just as in Android

[opusforlife2]

Advanced or 'Miscellaneous Settings' is a good option, I think. Newpipe isn't some critical application which will have planet destroying settings if the users don't know what they're doing. In the worst case, they'll disable comments or delete their main page tabs and be faced with the default blank page.

I say let them mess with advanced settings at their own risk. Put it behind a Firefox about:config like warning.

@B0pol Very good point. Main page content should be in Content.

Edit: Actually, why can't this be the default state? Have the description always expanded. The user anyway has to scroll down for comments or suggested videos. It won't have any major impact. In fact, it might even lessen their distraction level. I know I've tapped on the first few suggested videos in a chain without watching any, once in a while.

[opusforlife2]

Noooooooooooooooooo!

[git-mng]

what? [image: Mailtrack] <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&> Sender notified by Mailtrack <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&> 07/04/20, 19:54:22 Il giorno mar 7 apr 2020 alle ore 19:51 opusforlife2 < [email protected]> ha scritto:

…

Noooooooooooooooooo! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2998 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TAVOMSTGCZGRGWOMV733RLNRZLANCNFSM4KLHGIZQ> .

[gkeegan]

@B0pol why close? :(

[B0pol]

Because it was in 0.18.4 milestone, then 0.19.0, and not anymore in 0.19.3, and it has been pending for two months for a really small PR. Also, TobiGr has shown he's not really for it.