Hide controls when resumed by media keys

[Alexander--]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Hide controls after playback is paused by external media key.

Fixes the following issue(s)

Fixes #3403

Agreement

• I carefully read the contribution guidelines and agree to them.

[wb9688]

Kind of off-topic here, but do you happen to know whether we should actually do the following?

[Alexander--]

@wb9688

Not sure. This feature is mainly used by Play Store to determine if application supports Android TV devices. Probably won't hurt to add it.

[B0pol]

It doesn't fix #3403 for me.

[Alexander--]

@B0pol

This PR aims to fix very specific scenario, described by @Poomex in #3403 (comment). My testing indicates, that it works (resuming from pause by a media key hides controls).

You have never explained, what exactly you want to be happen. Do you want controls to always hide after two seconds?

[B0pol]

@B0pol

This PR aims to fix very specific scenario, described by @Poomex in #3403 (comment). My testing indicates, that it works (resuming from pause by a media key hides controls).

You have never explained, what exactly you want to be happen. Do you want controls to always hide after two seconds?

Ok, let's explain, and redo an issue template:

Steps to reproduce:

1. Play video
2. Press "pause" on the remote
3. Press "play" on the remote
4. The video starts playing again

Expected
The player controls should hide after a few seconds

Actual
The player controls remain on screen and disappear only when I press back button.

Very very similar.

Before we discuss, here are some resources so that everyone can understand:
Here is a screenshot of my remote to better visualize:

And here is the source for KeyEvent.java: https://bin.privacytools.io/?475a7df7aef6f7b8#/6H655SKxycccHSnnsY6J1ylgGwPhAml604odQMS2z4=

The problem is as step 4. My problem is using "OK" button, because I only use it, but some people could also have the same problem with play / pause.

Here is a comparison between versions / PRs:
With current version (0.19.3):

• When I press on "OK", keycode 23 (KEYCODE_DPAD_CENTER),
  it will resume, but not hide the controls after few seconds.
• When I press on pause resume (in MEDIA CENTER controls at the top), keycode 85 (KEYCODE_MEDIA_PLAY_PAUSE), it will resume but not hide controls after few seconds

With the patch Stypox provided, I have exactly this: #3403 (comment)

• When I press on "OK", keycode 23 (KEYCODE_DPAD_CENTER),
  it will resume, and hide controls after few seconds. I guess his play button is my "OK" button.
• When I press on pause resume (in MEDIA CENTER controls at the top), keycode 85 (KEYCODE_MEDIA_PLAY_PAUSE), it will resume but not hide controls after few seconds.

Stypox fixed the first situation, that's good. The second is not fixed, but it's not my usecase.

With your PR:

• When I press on "OK", keycode 23 (KEYCODE_DPAD_CENTER), it will resume but not hide controls after few seconds.
• When I press on pause resume (in MEDIA CENTER controls at the top), keycode 85 (KEYCODE_MEDIA_PLAY_PAUSE), it will resume but not hide after few seconds.

So nothing is fixed.

FYI, about lowering the delay, we talked about that on IRC, and yes, 2s can be short, but 7s is too long, and that's why Stypox changed to 5s.

[litetex]

No progress since a year, no GitHub actions build and merge conflicts.

Closing this issue for now. Feel free to reopen it when there is progress again.