Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yeast 8.3.3 #182

Merged
merged 31 commits into from
Dec 6, 2018
Merged

yeast 8.3.3 #182

merged 31 commits into from
Dec 6, 2018

Conversation

BenjaSanchez
Copy link
Contributor

@BenjaSanchez BenjaSanchez commented Dec 4, 2018

BenjaSanchez and others added 25 commits November 1, 2018 18:35
to comply with sysbio rulebook
* upload new biomass composition in physiology/biomassCompsition_Cofactor_Ion.tsv
* upload ion related exchange and transport rxns
* update all functions related to the change of new biomass
* upload the function of AddCofactorIon.m
run scaleBiomass will update the model with new biomass composition.
* update coefficients for NADH/NADP/NADPH/NAD
* change one rxn name to keep consistency
* fix the cd problem in the function
* fix a bug for rerun the function
rerun the function ScaleBiomass
* update the confidence score to be 2 for those rxns which have GPRs
* update coefficients for NAD/NADH/NADP/NADPH
corret the reference for 9 ions
delete unused variables
* change function name to avoid misleading.
"malate/β-methylmalate synthase", introduced in PR #156, creates parsing errors -> now it's stored as "malate/beta-methylmalate synthase"
PR #174 included "cofactor" & "ion" pseudo-metabolites, so addSBOterms.m should be modified accordingly
@BenjaSanchez BenjaSanchez added the new release PR from devel to master that leads to a new release label Dec 4, 2018
@BenjaSanchez BenjaSanchez self-assigned this Dec 4, 2018
change the function to let Ca2+ can enter into the cell freely
update in the model
Copy link
Collaborator

@hongzhonglu hongzhonglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really a big change. Using version 8.4 may be better!

@BenjaSanchez
Copy link
Contributor Author

@hongzhonglu even though there are many commits included, the model did not change significantly (less than 15 rxns), compared to e.g. release 8.3.0, where >200 rxns were added. I think increase to 8.3.3 is better suited, based on our contributing guidelines.

feiranl and others added 3 commits December 5, 2018 21:57
… update

fix the rxnconfidence scores for those reactions in this update:exchange reactions: NAN; reactions for modeling: 1
Fix biomass: Add Ca(2+) into Biomass
@BenjaSanchez BenjaSanchez merged commit 9c4737c into master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new release PR from devel to master that leads to a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants