Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keywords #173

Merged
merged 1 commit into from
Dec 2, 2018
Merged

fix: keywords #173

merged 1 commit into from
Dec 2, 2018

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

To comply with the sysbio rulebook:

  • Main utilization is "experimental data reconstruction"
  • Added "Bioreactor" keyword
  • Added omic sources
  • Added strain data
  • Removed "maximization of growth" from condition
  • Minor format changes

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

@BenjaSanchez
fix: keywords
0f0642f 
to comply with sysbio rulebook
@BenjaSanchez BenjaSanchez added the format fix things associated to format of any of the model/data/script files label Nov 1, 2018
@BenjaSanchez BenjaSanchez self-assigned this Nov 1, 2018
demilappa
demilappa approved these changes Dec 2, 2018
View reviewed changes
Copy link
Contributor

@demilappa demilappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pull request for fixes in the format of the README.md for yeast-GEM repository

@demilappa demilappa merged commit 7781e6b into devel Dec 2, 2018
@BenjaSanchez BenjaSanchez deleted the fix/keywords branch December 3, 2018 10:34
@BenjaSanchez BenjaSanchez mentioned this pull request Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demilappa demilappa demilappa approved these changes

@pecholleyc pecholleyc Awaiting requested review from pecholleyc

@mihai-sysbio mihai-sysbio Awaiting requested review from mihai-sysbio

Assignees

@BenjaSanchez BenjaSanchez

Labels
format fix things associated to format of any of the model/data/script files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaSanchez @demilappa