Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: annotate model after .mat and .yml export, but before .xml export #7

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

JonathanRob
Copy link
Collaborator

Main improvements in this PR:

As described in Issue 16 of Mouse-GEM and addressed in PR 18 of that same repo, the master script for regenerating the model files (masterScriptZebrafishGEM.m in this repo) is modified such that the addition of non-standard metabolite and reaction annotation fields are only added to the SBML (.xml) version of the model. The .mat and .yml versions should not contain these fields.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch

@JonathanRob JonathanRob merged commit 14367ae into develop Oct 10, 2022
@JonathanRob JonathanRob deleted the fix/masterScript branch October 10, 2022 16:58
@JonathanRob JonathanRob mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants