Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.mat model should not contain full annotation information #16

Closed
2 tasks done
Assignees

Comments

@JonathanRob
Copy link
Collaborator

Description of the issue:

The .mat model file (Mouse-GEM.mat) on the main branch contains all the additional metabolite and reaction annotations from the correspond .tsv files (likely added by annotateGEM function).

Note: The same issue is present for Fruitfly-GEM, so I suspect all the animal GEMs may need to be checked for this issue.

Expected feature/value/output:

The .mat version should not contain this additional annotation information (see Human-GEM.mat for comparison).

I hereby confirm that I have:

  • Done this analysis in the main branch of the repository
  • Checked that a similar issue does not exist already
@haowang-bioinfo
Copy link
Member

@JonathanRob thanks for making this issue.

Please let me know if the aim is to make animal GEMs to be consistent with HumanGEM, or else? if there was a discussion about this before?

@JonathanRob
Copy link
Collaborator Author

I don't think they need to be identical, but they should follow the same rules that are in place to prevent problems. Currently, loading the model from the .yml file produces a model that is different than if loaded from the .mat file. Also, the additional fields present in the .mat file are not recognized by most functions in e.g. RAVEN and therefore cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants