-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human 1.13 #441
Merged
Merged
Human 1.13 #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Remove duplicate reactions (addresses Issue 345)
Fix: Amend #403 by merging additional model fields from duplicated rxns
fix: set MAR05998 to be reversible
Update PMIDs with the papers that elucidate complex-subunit composition of mitochondrial pyruvate carrier
fix: curate GPR rule for MAR04926
fix: remove some empty fields from imported yaml model
…he tasks and reactions.tsv. This is good when using the code for for example Mouse-GEM.
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
… wrong folder - I added Human-GEM to the path.
Co-authored-by: Mihail Anton <[email protected]>
Fix: Remove reaction MAR02517
update HMDB IDs to version 4 format by inserting double zero
- Data source: DOI: 10.1126/science.aal3321
- The mapping of Swissprot Mitochondria and Inner mitochondria compartment is refined to catch the missing ones
The only "inner mitochondria" comparment assigned by SwissProt overrides "Mitochondria" assignment by Cell Atlas
feat: add compartment information to genes.tsv
fix: update HMDB IDs to version 4
feat: add compartment info from deeploc2 prediction
haowang-bioinfo
requested review from
JonathanRob,
mihai-sysbio,
feiranl and
johan-gson
December 21, 2022 14:18
feiranl
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
genes.tsv
based on SwissProt annotation, Cell Atlas, and deeploc2 prediction, as discussed in tabulate sub-cellular localizations for metabolic enzymes #436MAR02517
and 4 metabolites (MAM02444l
,MAM02678l
,MAM00890l
, andMAM01596l
) that were involved in no other reactions, to address issue MAR02517 should not be associated with the CTSA gene #381MAR09498
, as reported in MAR09498 (catalyzed by MGMT) should be irreversible #425prepHumanModelForftINIT
to take the paths toreactions.tsv
and essential tasks as optional parameters, as proposed in prepHumanModelForftINIT should take the paths to reactions.tsv and essential tasks as optional params #401importYaml
to get rid of empty and non-essential fieldsMAR05998
to be reversible, as proposed in Reaction MAR05998 should be listed as reversible #412