fix: remove some empty fields from imported yaml model #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
The
importYaml
function defines and creates a set of model fields at the start of import, which means that if some fields are missing from the.yml
file, the corresponding fields in the Matlab structure will be empty. Since some functions expect fields to be of a certain length (e.g., those relating to metabolites, genes, and reactions), empty fields may cause errors in those functions.This PR implements a change in the
importYaml
function that checks if any model fields are still empty at the end of the import process, and removes those fields. A few exceptions are included to avoid removing some fields which are OK to be empty (description
,version
).This PR also addresses an Issue in the Mouse-GEM repository.
I hereby confirm that I have:
develop
as a target branch