Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compartment information to genes.tsv #437

Merged
merged 9 commits into from
Dec 5, 2022

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented Dec 1, 2022

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch

@feiranl
Copy link
Collaborator

feiranl commented Dec 1, 2022

I will add the predicted compartment soon to this file.

@haowang-bioinfo
Copy link
Member Author

I will add the predicted compartment soon to this file.

maybe better to add prediction in another PR after this

@haowang-bioinfo haowang-bioinfo marked this pull request as ready for review December 1, 2022 09:38
Copy link
Member

@mihai-sysbio mihai-sysbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the localization source as a separate column in this file can get tricky. For example, when there are 3 localizations and 2 sources:

genes compartments compDataSource
ENSG00000003987 Golgi apparatus;Cytosol;Nucleus SwissProt&CellAtlas

This might mean agreement between sources, or it might mean that it is a "sum". To avoid this source of confusion, I suggest the removal of this column from genes.tsv. If the exact source is needed, one should look directly into the data files.

The only "inner mitochondria" comparment assigned by SwissProt overrides "Mitochondria" assignment by Cell Atlas
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haowang-bioinfo haowang-bioinfo merged commit 42dae44 into develop Dec 5, 2022
@haowang-bioinfo haowang-bioinfo deleted the feat/addCompartmentInfo branch December 5, 2022 17:35
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants