-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compartment information to genes.tsv #437
Conversation
- Data source: DOI: 10.1126/science.aal3321
- The mapping of Swissprot Mitochondria and Inner mitochondria compartment is refined to catch the missing ones
I will add the predicted compartment soon to this file. |
maybe better to add prediction in another PR after this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the localization source as a separate column in this file can get tricky. For example, when there are 3 localizations and 2 sources:
genes | compartments | compDataSource |
---|---|---|
ENSG00000003987 | Golgi apparatus;Cytosol;Nucleus | SwissProt&CellAtlas |
This might mean agreement between sources, or it might mean that it is a "sum". To avoid this source of confusion, I suggest the removal of this column from genes.tsv
. If the exact source is needed, one should look directly into the data files.
The only "inner mitochondria" comparment assigned by SwissProt overrides "Mitochondria" assignment by Cell Atlas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Main improvements in this PR:
genes.tsv
with two columns:compartments
andcompDataSource
I hereby confirm that I have:
develop
as a target branch