Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for evaluation phase and run more data #91

Merged
merged 6 commits into from
Sep 29, 2024
Merged

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Aug 28, 2024

petric.py Outdated Show resolved Hide resolved
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As computing the metrics does take time, let's set the interval of computing metrics to 3 to avoid overloading the system.

We will need to compute them every update for the final evaluation.

Otherwise, this PR is good to go.

petric.py Outdated Show resolved Hide resolved
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casperdcl can we merge this before PETRIC is over for participants to get more final feedback? Note the suggested change to compute metrics every 3 updates.

@KrisThielemans KrisThielemans marked this pull request as ready for review September 29, 2024 10:44
@KrisThielemans KrisThielemans changed the title evaluation phase prepare for evaluation phase and run more data Sep 29, 2024
@KrisThielemans KrisThielemans merged commit e549237 into main Sep 29, 2024
2 checks passed
@KrisThielemans KrisThielemans deleted the mMR_ACR branch September 29, 2024 12:56
Copy link
Member Author

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge this before PETRIC is over for participants to get more final feedback

hah not really much time for them to do anything about it. Especially given that people don't work on Sunday.

Also inconsistent interval @KrisThielemans ...

petric.py Show resolved Hide resolved
petric.py Show resolved Hide resolved
@KrisThielemans
Copy link
Member

sorry. mad rush. Please correct as you see fit. I won't touch it anymore.

@casperdcl casperdcl mentioned this pull request Oct 1, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants