-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare for evaluation phase and run more data #91
Conversation
casperdcl
commented
Aug 28, 2024
•
edited by KrisThielemans
Loading
edited by KrisThielemans
- depends on add DATA_SLICES #105
- evaluation phase: skip objective #82
- Finalise challenge data #18
- add mMR_ACR Siemens mMR_ACR updates #88
- add Mediso_NEMA Mediso NEMA IQ data #102
- add mMR_NEMA_lowcounts Siemens mMR NEMA IQ lowcounts #108
- add DMI3_Torso GE_DMI3_Torso dataset #111
c457221
to
34b28ee
Compare
06cb7cf
to
55d009b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As computing the metrics does take time, let's set the interval of computing metrics to 3 to avoid overloading the system.
We will need to compute them every update for the final evaluation.
Otherwise, this PR is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@casperdcl can we merge this before PETRIC is over for participants to get more final feedback? Note the suggested change to compute metrics every 3 updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we merge this before PETRIC is over for participants to get more final feedback
hah not really much time for them to do anything about it. Especially given that people don't work on Sunday.
Also inconsistent interval
@KrisThielemans ...
sorry. mad rush. Please correct as you see fit. I won't touch it anymore. |