Allow to specify CC and BCC in sender #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
force-pushed
the
allow-to-specify-cc-and-bcc-in-sender
branch
2 times, most recently
from
5f33e3f
to
acec554
Compare
lchrusciel
reviewed
Jun 23, 2022
| @@ -59,6 +67,23 @@ public function send(string $code, array $recipients, array $data = [], array $a | |||
|
|
|||
| $renderedEmail = $this->rendererAdapter->render($email, $data); | |||
|
|
|||
| if (count($arguments) > 5 && $this->senderAdapter instanceof CcAwareAdapterInterface) { | |||
There was a problem hiding this comment.
I'm wondering if we shouldn't cover the case, where someone is giving more than 5 arguments, but the sender is not CcAwareAdapterInterface
There was a problem hiding this comment.
If someone is giving more than 5 arguments and it's not CCAware... then it's fulfilling a different contract and should be customized nevertheless... I think so :D
Zales0123
force-pushed
the
allow-to-specify-cc-and-bcc-in-sender
branch
from
acec554
to
8b9adbd
Compare
lchrusciel
approved these changes
Jun 27, 2022
Roshyo
approved these changes
Jun 28, 2022
GSadee
approved these changes
Jun 28, 2022
|
Thank you, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #11, fixed, rebased and improved 🖖 My biggest concern is a
Sender- I wanted to avoid adding another interface (as I did withAdapterInterface), so I made some shenanigans with arguments counting... but I'm not convinced it's the best choice 🤷♂️ Still, BC breaks-free for sure.It would be great to merge it before 1.8 release 🚀