Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code from SenderInterface #221

Open
wants to merge 2 commits into
base: 3.0
Choose a base branch
from

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented Feb 7, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets #152
License MIT

We neglected to remove outdated code before the 2.0 release

@Rafikooo Rafikooo added the Maintenance Configurations, READMEs, releases, etc. label Feb 7, 2024
@Rafikooo Rafikooo requested a review from a team as a code owner February 7, 2024 21:19
@lchrusciel
Copy link
Member

The only problem with that is... we will have to release 3.0 xd

@Rafikooo
Copy link
Contributor Author

@lchrusciel

The only problem with that is... we will have to release 3.0 xd

https://github.com/Sylius/SyliusMailerBundle/pull/152/files#diff-d35d1dd923e4c4e041393cf2b058d9e1fb0556e5d6b71657f36b18c999c92b37R25

If I am seeing correctly, deprecations were introduced in[v1.8.0-BETA.1](https://github.com/Sylius/SyliusMailerBundle/releases/tag/v1.8.0-BETA.1) so couldn't we release a minor version like 2.2.0 instead?

@lchrusciel
Copy link
Member

Unfortunately, no, because once we released 2.0, we created a new contract. But it is not a big deal to do so

@Zales0123
Copy link
Member

Let's maybe just open a 3.0 branch, why not? 😅

@Zales0123 Zales0123 changed the base branch from 2.0 to 3.0 July 29, 2024 15:36
@Zales0123 Zales0123 force-pushed the sender-outdated-code branch 3 times, most recently from e85084b to 94a2b40 Compare July 29, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants