Deprecate uasge of SenderInterface without CC and BCC

ecs.php

@@ -2,6 +2,7 @@
 
 use PhpCsFixer\Fixer\ClassNotation\VisibilityRequiredFixer;
 use PhpCsFixer\Fixer\Comment\HeaderCommentFixer;
+use PhpCsFixer\Fixer\Phpdoc\NoSuperfluousPhpdocTagsFixer;
 use PhpCsFixer\Fixer\Phpdoc\PhpdocTagTypeFixer;
 use SlevomatCodingStandard\Sniffs\Commenting\InlineDocCommentDeclarationSniff;
 use Symplify\EasyCodingStandard\Config\ECSConfig;
@@ -25,6 +26,7 @@
         PhpdocTagTypeFixer::class,
         InlineDocCommentDeclarationSniff::class . '.MissingVariable',
         VisibilityRequiredFixer::class => ['*Spec.php'],
+        NoSuperfluousPhpdocTagsFixer::class => ['src/Component/Sender/SenderInterface.php'],
         '**/var/*',
         'src/Bundle/test/app/AppKernel.php',
     ]);

phpstan.neon

@@ -26,3 +26,5 @@ parameters:
         - '/Method Symfony\\Contracts\\EventDispatcher\\EventDispatcherInterface::dispatch\(\) invoked with 2 parameters, 1 required\./'
         - '/Cannot call method has\(\) on object\|null/'
         - '/Property Sylius\\Component\\Mailer\\Model\\Email\:\:\$id is never written\, only read\./'
+        - '/PHPDoc tag \@param references unknown parameter\: \$bccRecipients/'
+        - '/PHPDoc tag \@param references unknown parameter\: \$ccRecipients/'

psalm.xml

@@ -17,6 +17,12 @@
     </projectFiles>
 
     <issueHandlers>
+        <InvalidDocblockParamName>
+            <errorLevel type="suppress">
+                <file name="src/Component/Sender/SenderInterface.php" />
+            </errorLevel>
+        </InvalidDocblockParamName>
+
         <PossiblyNullReference>
             <errorLevel type="suppress">
                 <file name="src/Bundle/DependencyInjection/Configuration.php" />

src/Bundle/Sender/Adapter/SymfonyMailerAdapter.php

@@ -103,12 +103,8 @@ private function sendMessage(
             ->html($renderedEmail->getBody())
         ;
 
-        if (!empty($ccRecipients)) {
-            $message->addCc(...$ccRecipients);
-        }
-        if (!empty($bccRecipients)) {
-            $message->addBcc(...$bccRecipients);
-        }
+        $message->addCc(...$ccRecipients);
+        $message->addBcc(...$bccRecipients);
 
         foreach ($attachments as $attachment) {
             $message->attachFromPath($attachment);

src/Bundle/spec/Sender/Adapter/SymfonyMailerAdapterSpec.php

@@ -60,7 +60,7 @@ function it_sends_an_email_with_events(
                 $message->getBody()->bodyToString() === 'body' &&
                 $message->getFrom()[0] == new Address('[email protected]', 'arnaud') &&
                 $message->getTo()[0] == new Address('[email protected]')
-                ;
+            ;
         }))->shouldBeCalled();
 
         $dispatcher

src/Component/Sender/SenderInterface.php

@@ -16,9 +16,13 @@
 interface SenderInterface
 {
     /**
+     * @deprecated using this method without 2 last arguments ($ccRecipients and $bccRecipients) is deprecated since 1.8 and won't be possible since 2.0
+     *
      * @param string[]|null[] $recipients A list of email addresses to receive the message. Providing null or empty string in the list of recipients is deprecated and will be removed in SyliusMailerBundle 2.0
      * @param string[] $attachments A list of file paths to attach to the message.
      * @param string[] $replyTo A list of email addresses to set as the Reply-To address for the message.
+     * @param string[] $ccRecipients A list of email addresses set as carbon copy
+     * @param string[] $bccRecipients A list of email addresses set as blind carbon copy
      */
     public function send(
         string $code,