Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel and return button in settings page #28

Closed
JTFouquier opened this issue Mar 28, 2016 · 2 comments
Closed

Cancel and return button in settings page #28

JTFouquier opened this issue Mar 28, 2016 · 2 comments
Assignees
@gtsueng
Labels
enhancement ux

Comments

@JTFouquier
Copy link
Collaborator

If user accidentally makes changes they don't want to keep in the settings page, give them a way to cancel and return them to what they were doing. We don't want to get them in the habit of hitting the 'back' button in the browser, which is what they'll resort to.
@x0xMaximus
Copy link
Member

@gtsueng A cancel button was added, which essentially is just a link back to the profile page. This lets people cancel and go back. Is this resolved now?

x0xMaximus added a commit that referenced this issue Jul 6, 2016
@x0xMaximus
Addresses #28
2404a73
x0xMaximus added a commit that referenced this issue Jul 25, 2016
@x0xMaximus
Merge branch 'migrations-prior-css'
2f4b85c 
* migrations-prior-css: (21 commits)
  Addresses #184
  Addresses #189
  Addresses #180
  [Sentry] fixes #139428581 #139428586 #139610697
  [Redirect / URLs] not auth dashboard redirect
  [STATIC] new jquery 3.0.0 in repo
  [Small CSS] $color_error_red usage 4 back on Tree
  Addresses #102. Pull to prod.
  Addresses #102
  Addresses #28
  Quest loading css
  Addresses #11
  Addresses #135
  [Progress] Addresses #135
  Addresses #141
  More cleanup of verbose js imports from externals
  Closes #151
  Addresses #181
  Addresses #180
  Remove dangerous d3 import from group_home page.
  ...

# Conflicts:
#	static/css/style.css
#	static/scss/style.scss
@x0xMaximus
Copy link
Member

This hasn't been confirmed by @gtsueng but I just checked and my cancel button fulfills what this originally wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtsueng gtsueng

Labels
enhancement ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@x0xMaximus @JTFouquier @gtsueng