Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping concept highlighting in relation app #184

Open
JTFouquier opened this issue Jun 15, 2016 · 8 comments
Open

Overlapping concept highlighting in relation app #184

JTFouquier opened this issue Jun 15, 2016 · 8 comments
Assignees
@gtsueng
Labels
bug: low priority in progress

Comments

@JTFouquier
Copy link
Collaborator

The ability to have overlapping concepts was removed via the overlapping concept code at one point, but looks like it was reintroduced at some point. (see the title in the attached image)

screen shot 2016-06-15 at 4 28 38 pm
@x0xMaximus
Copy link
Member

Looks like this issue is no longer reproducible. Just looked at and appears to be resolved. @gtsueng can you please confirm this no longer is an issue and 1) can be closed 2) another example is provided where I can inspect what might be causing this cases

@gtsueng
Copy link
Collaborator

gtsueng commented Jul 11, 2016

I'm able to reproduce the issue. It may take awhile to find another example, though.
not resolved
Looks like it's the second relationship displayed for document 1562.
doesn t look resolved 2

@x0xMaximus
Copy link
Member

The pubtator API for this (http://localhost:8000/document/pubtator-new/12793312.json) appears to be returning annotations for both sections within the first passage (the title)

@x0xMaximus
Copy link
Member

This is caused by the assumption that annotations in the title and abstract will never overlap. This is not a safe assumption and this particular document is a case where the positions of an annotation happen to conflict.

@x0xMaximus
Copy link
Member

Correction, even after refining only the proper annotations to be included with the correct passage, there is still an overlap:

This poses the question of, what order or exclusion do we take? Do longest spans (parents) always cancel out and remove shorter annotations that intersect them?

x0xMaximus added a commit that referenced this issue Jul 25, 2016
@x0xMaximus
Addresses #184
8f34d00 
Creation of generic clean_passage_df_overlaps for managing potential DF text highlighting conflicts
x0xMaximus added a commit that referenced this issue Jul 25, 2016
@x0xMaximus
Merge branch 'migrations-prior-css'
2f4b85c 
* migrations-prior-css: (21 commits)
  Addresses #184
  Addresses #189
  Addresses #180
  [Sentry] fixes #139428581 #139428586 #139610697
  [Redirect / URLs] not auth dashboard redirect
  [STATIC] new jquery 3.0.0 in repo
  [Small CSS] $color_error_red usage 4 back on Tree
  Addresses #102. Pull to prod.
  Addresses #102
  Addresses #28
  Quest loading css
  Addresses #11
  Addresses #135
  [Progress] Addresses #135
  Addresses #141
  More cleanup of verbose js imports from externals
  Closes #151
  Addresses #181
  Addresses #180
  Remove dangerous d3 import from group_home page.
  ...

# Conflicts:
#	static/css/style.css
#	static/scss/style.scss
@x0xMaximus
Copy link
Member

@gtsueng just checking, can this be closed?

@gtsueng
Copy link
Collaborator

gtsueng commented Aug 10, 2016

I'd like to keep an eye on this one just a little longer. It's not a case I see too often.

@x0xMaximus
Copy link
Member

@gtsueng current status on this? Can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtsueng gtsueng

Labels
bug: low priority in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@x0xMaximus @JTFouquier @gtsueng