Integration Test Failing due to Unordered List #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ntlind
reviewed
Jul 3, 2024
| metadata_links = data[0].meta | ||
| assert len(metadata_links) == 1 | ||
| assert "metadatum1" in metadata_links | ||
| assert metadata_links["metadatum1"] == "temporary" |
There was a problem hiding this comment.
can you add back this assertion to make sure this change equivalent to the old test?
There was a problem hiding this comment.
The value isnt defined in the test so im not sure why this is necessary. The assertion is handled by datum.meta == md1 or datum.meta == md2
There was a problem hiding this comment.
There is no regression in test coverage so im confused why this matters.
ntlind
reviewed
Jul 3, 2024
| metadata_links = data[1].meta | ||
| assert len(metadata_links) == 2 | ||
| assert "metadatum2" in metadata_links | ||
| assert metadata_links["metadatum2"] == "a string" |
ntlind
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducible Example
`integration_tests/client/datasets/test_dataset.py::test_create_tabular_dataset_and_add_groundtruth`Issue Description
The test queries from postgres and treats the response as an ordered list which it is not.
Test failure is dependent on what order postgres returns its response.
Expected Behavior
The test should not assume an ordered response from postgres.