Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Integration Test Fails Randomly #653

Closed
1 task done
czaloom opened this issue Jul 3, 2024 · 0 comments · Fixed by #654
Closed
1 task done

BUG: Integration Test Fails Randomly #653

czaloom opened this issue Jul 3, 2024 · 0 comments · Fixed by #654
Assignees
@czaloom
Labels
bug Something isn't working

Comments

@czaloom
Copy link
Collaborator

czaloom commented Jul 3, 2024

valor version checks

  • I have confirmed this bug exists on the latest version of valor.

Reproducible Example

`integration_tests/client/datasets/test_dataset.py::test_create_tabular_dataset_and_add_groundtruth`

Issue Description

The test queries from postgres and treats the response as an ordered list which it is not.

Test failure is dependent on what order postgres returns its response.

Expected Behavior

The test should not assume an ordered response from postgres.
@czaloom czaloom added the bug Something isn't working label Jul 3, 2024
@czaloom czaloom self-assigned this Jul 3, 2024
@czaloom czaloom linked a pull request Jul 3, 2024 that will close this issue
Integration Test Failing due to Unordered List #654
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czaloom czaloom

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integration Test Failing due to Unordered List Striveworks/valor
1 participant
@czaloom