Determine the correct target before onFilter #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated PR with a fix for the index method. |
| // Check filter | ||
| if (typeof filter === 'function') { | ||
| if (filter.call(this, target, this)) { | ||
| _dispatchEvent(el, 'filter', target); | ||
| _dispatchEvent(el, 'filter', target, undefined, startIndex); |
There was a problem hiding this comment.
Is bad, onFilter should to work with evt.target.
Add variable originalTarget:
originalTarget = (touch || evt).target,
target = originalTarget
// ...
_dispatchEvent(el, 'filter', originalTarget, undefined, startIndex);There was a problem hiding this comment.
_dispatchEvent(originalTarget, 'filter', target, undefined, startIndex); ;]
|
|
||
| // get the index of the dragged element within its parent | ||
| startIndex = _index(target); | ||
|
|
||
| // Check filter | ||
| if (typeof filter === 'function') { | ||
| if (filter.call(this, target, this)) { |
There was a problem hiding this comment.
Updated PR. Also updated target -> originalTarget after the filter.split(',') line.
RubaXa
added a commit
that referenced
this pull request
Dec 8, 2014
Determine the correct target before onFilter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #156 and also returning correct indexes if a drag handle is present (#154).
How does this impact the example code for
closest?