Expose old & new element index on drag&drop #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I amend this commit to update the version in bower.json to 0.7.2, or do you want to do that? |
dandv
referenced
this pull request
Dec 8, 2014
|
Looks OK, change the version, run |
|
Done. |
|
Great! |
RubaXa
added a commit
that referenced
this pull request
Dec 8, 2014
Expose old & new element index on drag&drop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #148.
The
while (e = e.previousElementSibling) ++startIndexis very fast: 1.3ms for dragging the last of a 50,000-element list in Chrome on a Core i5.Might need testing on touch devices; please review. Thanks!