Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onFilter receives the handle if there is one #156

Closed
dandv opened this issue Dec 8, 2014 · 3 comments
Closed

onFilter receives the handle if there is one #156

dandv opened this issue Dec 8, 2014 · 3 comments
Labels
bug enhancement Quality of life changes to existing features

Comments

@dandv
Copy link
Contributor

dandv commented Dec 8, 2014

http://jsbin.com/sizila/1/edit?html,output

If you click on the handle of the filtered element, onFilter should receive the element, just like onStart

dandv added a commit that referenced this issue Dec 8, 2014
Fix #156 and also returning correct indexes if a drag handle is present (#154).
@dandv dandv added the bug label Dec 8, 2014
dandv added a commit that referenced this issue Dec 8, 2014
Fix #156 and also returning correct indexes if a drag handle is present (#154).
@dandv
Copy link
Contributor Author

dandv commented Dec 8, 2014

Is this not a bug then? If we dispatch filter with originalTarget, then I think this bug will still exist.

@RubaXa
Copy link
Collaborator

RubaXa commented Dec 8, 2014

No, this is not an bug, the function should work with the element on which the user clicked. But in order to maintain a uniform style, can change concept:

_dispatchEvent(originalTarget, 'filter', target, undefined, startIndex);

In closest example, replace evt.item on evt.target.

@RubaXa RubaXa added enhancement Quality of life changes to existing features bug and removed bug labels Dec 8, 2014
dandv added a commit that referenced this issue Dec 8, 2014
Fix #156 and also returning correct indexes if a drag handle is present (#154).
@dandv
Copy link
Contributor Author

dandv commented Dec 8, 2014

OK, amended PR.

dandv added a commit that referenced this issue Dec 8, 2014
Fix #156 and also returning correct indexes if a drag handle is present (#154).
RubaXa added a commit that referenced this issue Dec 8, 2014
@dandv dandv closed this as completed in 81748a5 Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement Quality of life changes to existing features
Projects
None yet
Development

No branches or pull requests

2 participants