Embed SonarC# and SonarVB 6.6

[duncanp-sonar]

Bug

• #535 - CSharp sensor should fail if OS is not windows.
• #803 - Fix S3242: Rule should not throw ArgumentException
• #819 - Fix S2325: 'Member should be static' throws NullReferenceException
• #834 - Fix S3242: Rule throws ArgumentException when 2+ params of method have the same name

False Positive

• #640 - Fix S3242: Rule should not report when more general type doesn't have indexer
• #680 - Fix S3242: Rule should not suggest IEnumerable when there are multiple iterations over the collection
• #705 - Fix S3242: Should not suggest base class for arguments when method has an event handler signature
• #782 - Fix S3242: Do not suggest ICollection<KVP<TKey, TValue>>
• #795 - Fix S4004: Rule should not raise a violation when [DataMember] is applied
• #809 - Fix S4070: False positive with combined values
• #813 - Fix S3242: Do not suggest IReadOnlyCollection interface instead of IReadOnlyList if collection items are accessed by index
• #828 - Fix S2758: false positive on conditional operator with interpolated string
• #863 - Fix S3242: Rule should not suggest base type resulting in inconsistent accessibility

Improvement

• #237 - Do not import files detected as autogenerated in SonarQube
• #364 - Improve test sensors to execute them only when the related property is defined
• #428 - Do not skip source files that contains "ExcludeFromCodeCoverage*" attributes
• #839 - Update S1226: "Parameter values should not be ignored" should be a bug
• #840 - Update S1751: "Unconditional jump statements" should be a code smell
• #841 - Update S2234: "Parameters should be passed in correct order" should be a code smell
• #842 - Update S2681: "Multiline blocks should be in curly braces" should be a code smell
• #843 - Update S3010: "Static fields should not be updated in constructors" should be a code smell
• #844 - Update S4158: "Empty collections should not be iterated" should be a bug
• #851 - Fix Cognitive Complexity Metric to detect recursion correctly
• #858 - Update release notes link in vsix manifest and nuget spec
• #862 - Improve test assembly detection logic
• #905 - Improve generated code recognition

New Feature

• #155 - Feed metric 'executable_lines_data' when SQ >= 6.2

External Contributors

• #814 Thanks @Chelaris182

Post-RC1 changes: minor fixes to detection of auto-generated code and calculation of executable lines of code.