Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test assembly detection logic #862

Closed
michalb-sonar opened this issue Oct 20, 2017 · 0 comments
Closed

Improve test assembly detection logic #862

michalb-sonar opened this issue Oct 20, 2017 · 0 comments
Assignees
@Evangelink
Milestone
6.6

Comments

@michalb-sonar
Copy link
Contributor

michalb-sonar commented Oct 20, 2017 •
edited by Evangelink
Loading

Actual behavior

The assembly detection looks if the name contains the word "test": https://github.com/SonarSource/sonar-csharp/blob/master/sonaranalyzer-dotnet/src/SonarAnalyzer.Common/Helpers/ProjectTypeHelper.cs

Therefore these will be considered test assemblies: BestEstimator, MyTestament or TheCutestPony.

Expected behavior

The previously quoted names should not be detected as test assemblies. Assembly name should be split by '.' and case and should contain test or tests as one of the split item.

Related information

SonarC# Version: 6.5
@michalb-sonar michalb-sonar added Area: Rules Type: False Negative Rule is NOT triggered when it should be. labels Oct 20, 2017
@Evangelink Evangelink added this to the 6.6 milestone Oct 24, 2017
@Evangelink Evangelink self-assigned this Oct 24, 2017
@Evangelink Evangelink mentioned this issue Oct 24, 2017
Merged
@duncanp-sonar duncanp-sonar removed the Type: False Negative Rule is NOT triggered when it should be. label Nov 7, 2017
@duncanp-sonar duncanp-sonar changed the title Test assembly detection logic is very naive Improve test assembly detection logic Nov 7, 2017
@duncanp-sonar duncanp-sonar mentioned this issue Nov 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
None yet
Projects
None yet
Milestone
6.6
Development

No branches or pull requests
3 participants
@duncanp-sonar @Evangelink @michalb-sonar