Rule S4070: Use xor operator to verify flags #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chelaris182
requested review from
duncanp-sonar,
Evangelink,
michalb-sonar and
valhristov
as code owners
Chelaris182
force-pushed
the
feature/4070
branch
from
a8c0f83
to
afd1e50
Compare
|
any follow up? |
|
Sorry for delay @Chelaris182, we had other priorities in the meantime. The PR solves the problems you identified. We will merge it to the following release of SonarC#. Thank you for contributing! |
michalb-sonar
changed the title
Evangelink
approved these changes
Oct 16, 2017
valhristov
approved these changes
Oct 18, 2017
Evangelink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rewrite of the rule to fix #809