Handle arguments with loads in Graphql mutations #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
such
force-pushed
the
am/fix-mutation-resolve
branch
from
5f63dfd
to
fed30a2
Compare
paracycle
reviewed
Jul 7, 2023
such
force-pushed
the
am/fix-mutation-resolve
branch
from
e16efa7
to
ab6e0aa
Compare
KaanOzkan
approved these changes
Jul 10, 2023
|
@paracycle is it good to be merged now? |
paracycle
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The generated sig is wrong when a Graphql mutation argument specifies a type that is automatically "loaded".
Implementation
Check whether each argument uses the loads keyword