fix generating incorrect type for custom scalars

[Tiedye]

Motivation

#1571 caused the graphql dsl compiler to return the incorrect type for custom scalars. Custom scalars define two methods coerce_input and coerce_result, in particular coerce_result generates the data that is returned to the mutation and this can be any type. T.untyped was correct

Implementation

Revert the offending change in #1571

Tests

Updated the existing tests

[paracycle]

I think instead of removing the whole Module fallback, what we really need to do is handle GraphQL::Schema::Scalar types explicitly right before that to generate T.untyped. Would that not fix the CustomScalar problem?

[Tiedye]

I think instead of removing the whole Module fallback, what we really need to do is handle GraphQL::Schema::Scalar types explicitly right before that to generate T.untyped. Would that not fix the CustomScalar problem?

I'll give it a go

[Tiedye]

I think instead of removing the whole Module fallback, what we really need to do is handle GraphQL::Schema::Scalar types explicitly right before that to generate T.untyped. Would that not fix the CustomScalar problem?

Yep that worked

[Tiedye]

@paracycle How's that look?

[nicoco007]

I think instead of removing the whole Module fallback, what we really need to do is handle GraphQL::Schema::Scalar types explicitly right before that to generate T.untyped. Would that not fix the CustomScalar problem?

Oh, I did something similar in #1659 that I think addresses this.

[Tiedye]

I think instead of removing the whole Module fallback, what we really need to do is handle GraphQL::Schema::Scalar types explicitly right before that to generate T.untyped. Would that not fix the CustomScalar problem?

Oh, I did something similar in #1659 that I think addresses this.

Nice! Yours is better, I'll close this if that gets merged