Handle arguments with loads in Graphql mutations

Shopify · Jul 7, 2023 · 5f63dfd · 5f63dfd
1 parent c83b87d
commit 5f63dfd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/lib/tapioca/dsl/compilers/graphql_mutation.rb b/lib/tapioca/dsl/compilers/graphql_mutation.rb
@@ -42,7 +42,7 @@ module Compilers
       class GraphqlMutation < Compiler
         extend T::Sig
 
-        ConstantType = type_member { { fixed: T.class_of(GraphQL::Schema::InputObject) } }
+        ConstantType = type_member { { fixed: T.class_of(GraphQL::Schema::Mutation) } }
 
         sig { override.void }
         def decorate
@@ -59,7 +59,11 @@ def decorate
           params = compile_method_parameters_to_rbi(method_def).map do |param|
             name = param.param.name
             argument = arguments_by_name.fetch(name, nil)
-            create_typed_param(param.param, argument ? Helpers::GraphqlTypeHelper.type_for(argument.type) : "T.untyped")
+            type = argument.loads ? GraphQL::Schema::Wrapper.new(argument.loads) : argument.type if argument
+            create_typed_param(
+              param.param,
+              argument ? Helpers::GraphqlTypeHelper.type_for(type) : "T.untyped",
+            )
           end
 
           root.create_path(constant) do |mutation|

diff --git a/spec/tapioca/dsl/compilers/graphql_mutation_spec.rb b/spec/tapioca/dsl/compilers/graphql_mutation_spec.rb
@@ -100,6 +100,10 @@ def resolve(body:, post_id:)
 
             it "generates correct RBI for all graphql types" do
               add_ruby_file("create_comment.rb", <<~RUBY)
+                class LoadedType < GraphQL::Schema::Object
+                  field "foo", type: String
+                end
+
                 class EnumA < GraphQL::Schema::Enum
                   value "foo"
                 end
@@ -127,8 +131,9 @@ class CreateComment < GraphQL::Schema::Mutation
                   argument :enum_b, EnumB, required: true
                   argument :input_object, CreateCommentInput, required: true
                   argument :custom_scalar, CustomScalar, required: true
+                  argument :loaded_argument, ID, required: true, loads: LoadedType
 
-                  def resolve(boolean:, float:, id:, int:, date:, datetime:, json:, string:, enum_a:, enum_b:, input_object:, custom_scalar:)
+                  def resolve(boolean:, float:, id:, int:, date:, datetime:, json:, string:, enum_a:, enum_b:, input_object:, custom_scalar:, loaded_argument:)
                     # ...
                   end
                 end
@@ -138,8 +143,8 @@ def resolve(boolean:, float:, id:, int:, date:, datetime:, json:, string:, enum_
                 # typed: strong
 
                 class CreateComment
-                  sig { params(boolean: T::Boolean, float: ::Float, id: ::String, int: ::Integer, date: ::Date, datetime: ::Time, json: T::Hash[::String, T.untyped], string: ::String, enum_a: ::String, enum_b: T.any(::String, ::Symbol), input_object: ::CreateCommentInput, custom_scalar: T.untyped).returns(T.untyped) }
-                  def resolve(boolean:, float:, id:, int:, date:, datetime:, json:, string:, enum_a:, enum_b:, input_object:, custom_scalar:); end
+                  sig { params(boolean: T::Boolean, float: ::Float, id: ::String, int: ::Integer, date: ::Date, datetime: ::Time, json: T::Hash[::String, T.untyped], string: ::String, enum_a: ::String, enum_b: T.any(::String, ::Symbol), input_object: ::CreateCommentInput, custom_scalar: T.untyped, loaded_argument: T.untyped).returns(T.untyped) }
+                  def resolve(boolean:, float:, id:, int:, date:, datetime:, json:, string:, enum_a:, enum_b:, input_object:, custom_scalar:, loaded_argument:); end
                 end
               RBI