Make sure we can type GraphQL object with anonymous input fields #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the class is anonymous, `qualified_name_of` returns `nil`. This means that `type_for` would raise an exception, causing the rbi generator to fail. Instead, we should be just returning `T.untyped` for that case.
There is no need for the instance, so just make it a module.
sambostock
approved these changes
Sep 13, 2022
|
That PR wan't handling the case when the one of values of the enum was anonymous. Not that I think it should happen, but better to be safe. |
This will also fix Ruby 2.7 problem that doesn't work with include in singleton classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the class is anonymous,
qualified_name_ofreturnsnil. Thismeans that
type_forwould raise an exception, causing the rbi generatorto fail.
Implementation
Return
T.untypedfor the anonymous caseOther info
Those commits are already applied to master (I used VSCode to sync the code and it end up pushing the changes), so this is only for the 0-10-stable branch.