map anonymous GraphQL InputObjects to T.untyped #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraphQLTypeHelper assumes that all classes have names. Anonymous classes don't have names and cause a T.must assertion to blow up. This replaces the T.must, instead returning T.untyped if an anonymous InputObject is encountered.
paracycle
reviewed
Sep 2, 2022
| end | ||
|
|
||
| parsed_type = T.must(parsed_type) | ||
| return "T.untyped" if parsed_type.nil? |
There was a problem hiding this comment.
Nitpick: can we change this to:
Suggested change
| return "T.untyped" if parsed_type.nil? | |
| parsed_type = "T.untyped" unless parsed_type |
This makes sure that the rest of the code has a chance to run, in case any logic we add want to make use of the type at this point.
For example, the T::Array case 2 lines below might need to use the type here to get T::Array[T.untyped]
| @@ -57,6 +57,7 @@ class CreateCommentInput < GraphQL::Schema::InputObject | |||
| class CreateCommentInput < GraphQL::Schema::InputObject | |||
| argument :body, String, required: true | |||
| argument :post_id, ID, required: true | |||
| argument :signature, Class.new(GraphQL::Schema::InputObject), required: true | |||
There was a problem hiding this comment.
Based on my comment above, can you also add an argument with [Class.new(GraphQL::Schema::InputObject)] type?
|
Sorry @ryanquanz I end up fixing this before looking on this PR in ad74c72. Really sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When run
tapioca dslagainst a GraphQLType that used an anonymous class inheriting from InputObject, I was seeing errors like these:(when sorbet assertions are being enforced)
(when sorbet assertions are not being enforced)
The problem appears to be that
Tapioca::Dsl::Helpers::GraphqlTypeHelper#type_forwhen receiving a descendant ofGraphQL::Schema::InputObjectassumes it will have a name, but with anonymous classes that is not the case:tapioca/lib/tapioca/dsl/helpers/graphql_type_helper.rb
Lines 16 to 47 in 9c6e115
Implementation
I replace the
T.mustwith a guard to returnT.untyped, I'm not sure if we could make a more precise type determination?Tests
I have augmented a test - hopefully it suffices as replication instructions.