Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we can type GraphQL object with anonymous input fields #1162

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Make sure we can type GraphQL object with anonymous input fields #1162

merged 3 commits into from
Sep 13, 2022

Commits on Sep 13, 2022

  1. Make sure we can type GraphQL object with anonymous input fields 

    When the class is anonymous, `qualified_name_of` returns `nil`. This
means that `type_for` would raise an exception, causing the rbi generator
to fail.

Instead, we should be just returning `T.untyped` for that case.
    @rafaelfranca
    rafaelfranca committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    36e3b65 View commit details
    Browse the repository at this point in the history

  2. Make GraphqlTypeHelper a singleton 

    There is no need for the instance, so just make it a module.
    @rafaelfranca
    rafaelfranca committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    efb1766 View commit details
    Browse the repository at this point in the history

  3. No need to include all methods if all we need is one 

    This will also fix Ruby 2.7 problem that doesn't work
with include in singleton classes.
    @rafaelfranca
    rafaelfranca committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    a42d424 View commit details
    Browse the repository at this point in the history