Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Update Prettier #1124

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Update Prettier #1124

merged 2 commits into from
Oct 16, 2019

Conversation

cartogram
Copy link
Contributor

@cartogram cartogram commented Oct 16, 2019

Description

This PR updates prettier to version 1.17.0. Prettier was originally installed in this PR #203, and hasn't changed in the ~14 months since.

When updating our eslint dependencies (in this PR), the updates to eslint-config-prettier/eslint-plugin-prettier modifies our prettier version.

Rather than keep the prettier changes for when we update our eslint/eslint-plugin-shopify versions (which are distracting and formatting only), I've pulled them out here. I cannot bump this repo right to the latest version (1.18.2) because of an incompatibility with our version of Typescript (documented here).

@ismail-syed
Copy link
Contributor

I cannot bump this repo right to the latest version (1.18.2) because of an incompatibility with our version of Typescript (documented here).

Are there any other reasons other than quilt being on an older version of TS? I would vote to bump it to the latest anyways because

  • It aligns with our engineering values. Keeping our tools up to date encourages consuming projects to stay up to date.
  • Our eslint plugin is used org-wide. Quilt might still be on an older version of TS, but that doesn't mean other projects aren't.

@cartogram
Copy link
Contributor Author

@ismail-syed yeah, we agree. I'm going to do the eslint-plugin-shopify prettier update, but in this PR I am bringing us as close as we can without needing to bump TS as well. Does that make sense?

Copy link
Contributor

@ismail-syed ismail-syed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't 🎩, we already have at least a couple medium/large codebases using prettier v18 so this should be 👍

I've been waiting ~2 years for this day - context. v1.17 includes a --quote-props option, 🎉. Are we able to set this in our default prettier config so it's as-needed? It's what we used to use in our eslint config setting

Aside from that, this is 💯


Summary of the important changes for posterity:

@ismail-syed
Copy link
Contributor

ismail-syed commented Oct 16, 2019

facepalm... I just had the biggest brain fart. For some reason, I thought this was a PR for eslint-plugin-shopify. 😅

@cartogram cartogram merged commit 5cfa5a8 into master Oct 16, 2019
@cartogram cartogram deleted the deps-update branch October 16, 2019 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants