You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
TLDR: Updating Prettier to the latest minor version requires us to be on Typescript 3.3 or later.
When attempting to update to the latest minor version of Prettier, I encountered an issue where the formatted TypeScript output added a trailing comma to Tuples.
For example
// BeforeexportfunctionuseSomeHook(): [string,string]{/*...*/}// After exportfunctionuseSomeHook(): [string,string,<--Trailingcomma]{/*...*/}
This is a problem because our version of Typescript does not support trailing commas on Tuples. It looks like they were were added in Typescript 3.3 via this PR.
Work has already been started in this PR to upgrade Typescript. When that is shipped, we can upgrade to the latest prettier.
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
stalebot
added
the
stale
Stale issue that hasn't received any attention in a while
label
Oct 4, 2020
TLDR: Updating Prettier to the latest minor version requires us to be on Typescript 3.3 or later.
When attempting to update to the latest minor version of Prettier, I encountered an issue where the formatted TypeScript output added a trailing comma to
Tuples
.For example
This is a problem because our version of Typescript does not support trailing commas on Tuples. It looks like they were were added in Typescript 3.3 via this PR.
Work has already been started in this PR to upgrade Typescript. When that is shipped, we can upgrade to the latest prettier.
The text was updated successfully, but these errors were encountered: