Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Update eslint-plugin-shopify to the latest version 🚀 #203

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jul 16, 2018

Version 23.0.0 of eslint-plugin-shopify was just published.

Dependency eslint-plugin-shopify
Current Version 22.1.0
Type devDependency

The version 23.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of eslint-plugin-shopify.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes v23.0.0

Added

  • shopify/jsx-prefer-fragment-wrappers (#94)
  • shopify/jest/no-vague-titles (#93)
  • shopify/strict-component-boundaries (#98)
  • shopify/prefer-pascal-case-enums (#96)
  • shopify/react-prefer-private-members (#95)

Changed

  • Breaking Moved prettier to be a peerDependency, this avoids the potential for having multiple versions of prettier in the dependency graph. If you use prettier you will need to ensure you have it installed in your project as eslint-plugin-shopify will no longer install it for you (#107)
  • Breaking Updated typescript-eslint-parser to support [email protected] (#102)
  • Updated eslint-plugin-sort-class-members dependency to version 1.3.1 in order to support node 10.
  • Support for TypeScript 2.8
  • Fixed the publish config for the package.
Commits

The new version differs by 20 commits.

  • 0319b86 v23.0.0
  • 958547d Adds missing properties (#106)
  • a00afe7 fix jsx-prefer-fragment-wrappers (#112)
  • a480088 Merge pull request #105 from Shopify/add-missing-configs
  • b6fc2d6 Add missing configs to turn on rulls
  • 534e582 Merge pull request #109 from Shopify/fix-no-vague-titles
  • 4930fe0 prevent reading name from undefined callee.object
  • 024c982 Bump typescript-eslint-parser version (#102)
  • 17d5ed4 Merge pull request #107 from Shopify/prettier-peerdep
  • 4d2105f Move prettier to be a peer dependency
  • d13fdbc Merge pull request #98 from Shopify/strict-component-boudaries
  • 5edcffc adds strict-component-boundaries rule
  • 3db1439 Merge pull request #100 from Shopify/add-new-rules
  • ef53ab1 Merge pull request #93 from Shopify/no-tests-contain-correct
  • 0827edc Add no-tests-contain-correct rule

There are 20 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Aug 2, 2018

Version 23.1.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 5 commits.

  • c4e2c1d v23.1.0
  • 849c3a4 Update changelog for a 23.1.0 release (#131)
  • 1726cfb Fix links to changelog diffs (#125)
  • 55b8c56 Remove inline Prettier configs (fixes #118) (#121)
  • 3d930b0 Add 'all' to vague terms in no-vague-titles (#114)

See the full diff

@TzviPM TzviPM self-assigned this Aug 2, 2018
@TzviPM TzviPM force-pushed the greenkeeper/eslint-plugin-shopify-23.0.0 branch from bac5ae2 to b53e38a Compare August 2, 2018 17:47
@TzviPM TzviPM force-pushed the greenkeeper/eslint-plugin-shopify-23.0.0 branch from b53e38a to 31750c9 Compare August 2, 2018 17:48
@TzviPM TzviPM self-requested a review August 2, 2018 17:48
Copy link
Contributor

@TzviPM TzviPM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 all fixed up

@TzviPM TzviPM requested a review from marutypes August 2, 2018 18:55
@TzviPM TzviPM merged commit 1a2f376 into master Aug 2, 2018
@TzviPM TzviPM deleted the greenkeeper/eslint-plugin-shopify-23.0.0 branch August 2, 2018 21:09
@TzviPM TzviPM deployed to production August 2, 2018 21:20 Active
@cartogram cartogram mentioned this pull request Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants