Supporting types and implementations for replacing SeaORM's ColumnType
#579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
billy1624
changed the title
PartialEq for ColumnTypeColumnType and IdenStatic
ikrivosheev
reviewed
Jan 12, 2023
src/types.rs
Outdated
| @@ -66,6 +66,36 @@ impl fmt::Debug for dyn Iden { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| pub enum Identity { | |||
There was a problem hiding this comment.
@billy1624 can you explain, why you move this enum to SeaQuery? I cannot find place, where we can use it in SeaQuery
There was a problem hiding this comment.
Hey @ikrivosheev, it's true that Identity and IntoIdentity aren't used in any part of SeaQuery at the moment. It originally reside in SeaORM because we replace SeaORM's IdenStatic with sea_query::IdenStatic, this make it impossible to define impl<T: IdenStatic> IntoIdentity for T and hence moving both into SeaQuery.
Btw, IdenList trait can be replaced by IntoIdentity in the future, i.e. methods that originally take IdenList parameter can now take IntoIdentity instead.
billy1624
force-pushed
the
impl-partial-eq-for-column-type
branch
from
f707a58 to
4d49c88
Compare
billy1624
changed the title
ColumnType and IdenStaticColumnType
4 tasks
tyt2y3
approved these changes
Jan 18, 2023
|
|
|
Oh, we should always first merge into master then backport to a release branch instead. |
tyt2y3
pushed a commit
that referenced
this pull request
Jan 18, 2023
…pe` (#579) * Implements `PartialEq` for `ColumnType` * Add helper function to construct `ColumnType::Custom`
billy1624
added a commit
that referenced
this pull request
Apr 8, 2023
* sea-query-rusqlite 0.2.0 * Postgres `GEN_RANDOM_UUID` #568 * 0.28.1 * Convert various UUID defined in `uuid::fmt` module into `sea_query::Value::Uuid` * Merge pull request #550 from beckend/cow add Cow<str> conversion to Value * 0.28.2 * 0.28.2 * CI * Get values from UpdateStatement * Update CHANGELOG.md * Supporting types and implementations for replacing SeaORM's `ColumnType` (#579) * Implements `PartialEq` for `ColumnType` * Add helper function to construct `ColumnType::Custom` * Changelog * Tweaks * 0.28.3 * Fix: comma separator for dropping multiple types in Postgres. * Add: doc-test for dropping multiple types in Postgres. * Formatted documentation code. * fix: enable required `syn` features * Update CHANGELOG.md * Revert "Update CHANGELOG.md" This reverts commit eea846e. * Revert "fix: enable required `syn` features" This reverts commit 032348e. * Refactoring: using fold method instead of loop. * Update CHANGELOG.md --------- Co-authored-by: Billy Chan <[email protected]> Co-authored-by: Chris Tsang <[email protected]> Co-authored-by: PreetamSing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Dependents:
ColumnTypeandIdenStaticwith its SeaQuery's counterparts sea-orm#1390Cherry pick this back to the master branch
New Features
PartialEqforColumnTypeEqandPartialEqforMySqlYearEqandPartialEqforBlobSizeColumnType::customhelper function for constructingColumnType::Customfrom&str