add Cow<str> conversion to Value #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikrivosheev
reviewed
Dec 13, 2022
ikrivosheev
reviewed
Dec 13, 2022
ikrivosheev
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
@beckend thank you! LGTM! @billy1624 @tyt2y3 can someone review PR?
ikrivosheev
reviewed
Dec 13, 2022
deal with box
ikrivosheev
reviewed
Dec 13, 2022
|
Thanks, my internet is dead, had to edit in mobile |
ikrivosheev
approved these changes
Dec 13, 2022
billy1624
reviewed
Dec 14, 2022
src/value.rs
Outdated
| } | ||
|
|
||
| fn column_type() -> ColumnType { | ||
| ColumnType::Text |
There was a problem hiding this comment.
I think ColumnType::String(None) is more appropriate and it align with the implementation of impl ValueType for String.
billy1624
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Hey @beckend, thanks for contributions!
Just a small nitpick: https://github.com/beckend/sea-query/pull/1
Lifetime elided
billy1624
approved these changes
Dec 15, 2022
billy1624
pushed a commit
to billy1624/sea-query
that referenced
this pull request
Jan 4, 2023
add Cow<str> conversion to Value
billy1624
pushed a commit
that referenced
this pull request
Jan 4, 2023
add Cow<str> conversion to Value
billy1624
added a commit
that referenced
this pull request
Apr 8, 2023
* sea-query-rusqlite 0.2.0 * Postgres `GEN_RANDOM_UUID` #568 * 0.28.1 * Convert various UUID defined in `uuid::fmt` module into `sea_query::Value::Uuid` * Merge pull request #550 from beckend/cow add Cow<str> conversion to Value * 0.28.2 * 0.28.2 * CI * Get values from UpdateStatement * Update CHANGELOG.md * Supporting types and implementations for replacing SeaORM's `ColumnType` (#579) * Implements `PartialEq` for `ColumnType` * Add helper function to construct `ColumnType::Custom` * Changelog * Tweaks * 0.28.3 * Fix: comma separator for dropping multiple types in Postgres. * Add: doc-test for dropping multiple types in Postgres. * Formatted documentation code. * fix: enable required `syn` features * Update CHANGELOG.md * Revert "Update CHANGELOG.md" This reverts commit eea846e. * Revert "fix: enable required `syn` features" This reverts commit 032348e. * Refactoring: using fold method instead of loop. * Update CHANGELOG.md --------- Co-authored-by: Billy Chan <[email protected]> Co-authored-by: Chris Tsang <[email protected]> Co-authored-by: PreetamSing <[email protected]>
🎉 Released In 0.29.1 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Support Cow<str|String> #548
New Features
Value can now be converted from
Cow<str>