Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres GEN_RANDOM_UUID #568

Closed
billy1624 opened this issue Dec 29, 2022 · 6 comments · Fixed by #569
Closed

Postgres GEN_RANDOM_UUID #568

billy1624 opened this issue Dec 29, 2022 · 6 comments · Fixed by #569

Comments

@billy1624
Copy link
Member

Description

This should be GEN_RANDOM_UUID

sea-query/src/backend/postgres/query.rs

Line 81 in 46a4170

PgFunction::GetRandomUUID => "GET_RANDOM_UUID",

Additional Information

Test case: https://dbfiddle.uk/VSgTB_Qo

Related PR: #530
@tyt2y3
Copy link
Member

tyt2y3 commented Dec 29, 2022

Umm most likely a typo, let's do a patch release to 0.28

@billy1624
Copy link
Member Author

And we better rename PgFunction::GetRandomUUID to PgFunction::GenRandomUUID

@siketyan siketyan mentioned this issue Dec 29, 2022
Merged
@siketyan
Copy link
Contributor

I have created a small patch for this.
Should we remain get_random_uuid function for backward compatibility? or delete completely?

@tyt2y3
Copy link
Member

tyt2y3 commented Dec 29, 2022 •
edited
Loading

Thank you for the PR. Yes, we have to keep the old function for the patch release but remove it in the next major release.
I'll do it ! No worries

tyt2y3 added a commit that referenced this issue Dec 29, 2022
@tyt2y3
Postgres GEN_RANDOM_UUID #568
909fee1
@siketyan
Copy link
Contributor

@tyt2y3 Thank you! I have allowed editing the PR, so it is ok if you are going to edit the branch directly

@tyt2y3
Copy link
Member

tyt2y3 commented Dec 29, 2022

https://github.com/SeaQL/sea-query/releases/tag/0.28.1 Should fix the problem for now, and your PR would be merged for the next release

billy1624 added a commit that referenced this issue Apr 8, 2023
@ikrivosheev @billy1624
@tyt2y3 @PreetamSing
0.28.x into master (#629)
37e588e 
* sea-query-rusqlite 0.2.0

* Postgres `GEN_RANDOM_UUID` #568

* 0.28.1

* Convert various UUID defined in `uuid::fmt` module into `sea_query::Value::Uuid`

* Merge pull request #550 from beckend/cow

add Cow<str> conversion to Value

* 0.28.2

* 0.28.2

* CI

* Get values from UpdateStatement

* Update CHANGELOG.md

* Supporting types and implementations for replacing SeaORM's `ColumnType` (#579)

* Implements `PartialEq` for `ColumnType`

* Add helper function to construct `ColumnType::Custom`

* Changelog

* Tweaks

* 0.28.3

* Fix: comma separator for dropping multiple types in Postgres.

* Add: doc-test for dropping multiple types in Postgres.

* Formatted documentation code.

* fix: enable required `syn` features

* Update CHANGELOG.md

* Revert "Update CHANGELOG.md"

This reverts commit eea846e.

* Revert "fix: enable required `syn` features"

This reverts commit 032348e.

* Refactoring: using fold method instead of loop.

* Update CHANGELOG.md

---------

Co-authored-by: Billy Chan <[email protected]>
Co-authored-by: Chris Tsang <[email protected]>
Co-authored-by: PreetamSing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: get_random_uuid -> gen_random_uuid yumemi-inc/sea-query
3 participants
@tyt2y3 @siketyan @billy1624