Remove iris.plot.outline workaround
#4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is one decade and three days since this workaround went in! #109 |
trexfeathers
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Impressive memory as always @rcomer! This looks good to me.
|
Thanks @trexfeathers!
Looking at #4149 in yesterday's Peloton meeting jogged it. Yay Peloton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
iplt.outlinecontains an ancient workaround for a Matplotlib bug raised at matplotlib/matplotlib#1302 and fixed by matplotlib/matplotlib#18480, which was included in Matplotlib v3.4. Since Matplotlib is now pinned to >=3.5 (#4998), we can safely remove the workaround. I also here remove a test which expected the old behaviour, and failed when we tested against mpl v3.4.1 (#4090).Closes #4090.
Consult Iris pull request check list