Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iris.plot.outline workaround #4999

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Remove iris.plot.outline workaround #4999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/src/whatsnew/latest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ This document explains the changes made to Iris for this release
#. `@trexfeathers`_ adapted the benchmark for importing :mod:`iris.palette` to
cope with new colormap behaviour in Matplotlib `v3.6`. (:pull:`4998`)

#. `@rcomer`_ removed a now redundant workaround for an old matplotlib bug,
highlighted by :issue:`4090`. (:pull:`4999`)

.. comment
Whatsnew author names (@github name) in alphabetical order. Note that,
Expand Down
5 changes: 0 additions & 5 deletions lib/iris/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,11 +1344,6 @@ def outline(cube, coords=None, color="k", linewidth=None, axes=None):
axes=axes,
)

# set the _is_stroked property to get a single color grid.
# See https://github.com/matplotlib/matplotlib/issues/1302
result._is_stroked = False
if hasattr(result, "_wrapped_collection_fix"):
result._wrapped_collection_fix._is_stroked = False
return result


Expand Down
6 changes: 0 additions & 6 deletions lib/iris/tests/test_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,6 @@ def test_pcolormesh(self):
iplt.pcolormesh(self.cube)
self.check_graphic()

def test_grid(self):
iplt.pcolormesh(self.cube, facecolors="none", edgecolors="blue")
# the result is a graphic which has coloured edges. This is a mpl bug,
# see https://github.com/matplotlib/matplotlib/issues/1302
self.check_graphic()

def test_outline(self):
iplt.outline(self.cube)
self.check_graphic()
Expand Down