-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptions for Matplotlib 3.6 #4998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks cool, though I did have a bit of a wobble about requiring Matplotlib >= 3.5.
That is now ~10months old. But I guess this is anyway not an actual Iris dependency, its only for CI,
so I think that is fine.
Nice work @trexfeathers . We'll see how it goes tomorrow morning ! |
This is genuine. When this is released (December), Matplotlib 3.4 will not be usable with Iris |
Ok, hadn't really thought of it that way. |
This raises interesting questions about proactively responding to deprecation warnings. We typically don't spot them until the deprecation fully happens, and therefore don't experience the problem of very 'young' pins. In this case I spotted the warning while investigating and chose to action it, introducing this different problem! |
🚀 Pull Request
Description
These changes address a Matplotlib deprecation warning, and should get the overnight benchmarks working again.
Consult Iris pull request check list