-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netcdf separate loadsave #4803
Netcdf separate loadsave #4803
Conversation
Status update : |
fb52365
to
d9ef767
Compare
d9ef767
to
1864b6d
Compare
4cab4e2
to
e15b0b1
Compare
Rebased onto main, following #4794 |
Hi @trexfeathers I think this is now ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine, but there are some minor points I don't understand so hopefully you can help me with those.
Brilliant thanks @jamesp . |
UPDATE: oops, put this on the wrong issue ! |
b68b234
to
4cb6aca
Compare
4cb6aca
to
824286e
Compare
Thanks @trexfeathers . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the responses @pp-mo, and sorry for the delay.
Please could you add a What's New entry under the Internal
heading, as this change is important to flag for developers.
Please also shout if merging this now is going to cause any problems with the Split cube-attrs project. Perhaps it's worth the problems 😅
Good thought, but should be nothing serious I think -- this has only moved things, not reorganised. |
I've been re-running some missed benchmarks. FWIW you would have seen this (predictable I suppose!):
|
This "just" splits the iris.fileformats.netcdf module into separate sourcefiles for load + save code.
There's very little talk between the two, and this should makes it much easier for devs to find their way around.
Note that I haven't forced the split upon the user : All the public API is exported in the parent module, so everything there is as it was.
TODO: in draft while I test with Cirrus-Ci memory hacks, just to run the tests.