Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris Documentation: Needs to be dark mode friendly #4795

Closed
1 of 3 tasks
tkknight opened this issue Jun 13, 2022 · 4 comments
Closed
1 of 3 tasks

Iris Documentation: Needs to be dark mode friendly #4795

tkknight opened this issue Jun 13, 2022 · 4 comments

Comments

@tkknight
Copy link
Contributor

tkknight commented Jun 13, 2022

📚 Documentation

pydata-sphinx-theme has been updated from 0.8.1 to 0.9.0. The later version supports dark mode which is great, however the iris docs will need a few changes like image transparency, dark friendly logo, etc.

image

The biggest item to fix is the expandable panels colours are not associated with the theme (always white).

image

Suggest we:

@trexfeathers
Copy link
Contributor

dark friendly logo

#3935

@rcomer
Copy link
Member

rcomer commented Jun 16, 2022

Dark mode is already showing in the latest docs 😕

ECCD371D-3A6A-44AA-B6E9-91023FCC1501

@tkknight
Copy link
Contributor Author

I believe that is due to readthedocs (latest) using the main branch for the requirements, that use use the env definition https://github.com/SciTools/iris/blob/main/requirements/ci/readthedocs.yml (symlink to iris.yml -> py38.yml).

PR #4796 to pin to the non dark mode version has not been merged just yet. We have some CI issues atm so the PR will not pass - feel free to merge though, it is a minor change.

@trexfeathers
Copy link
Contributor

@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants