Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmarks netcdf import #5001

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Fix benchmarks netcdf import #5001

merged 2 commits into from
Sep 29, 2022

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

  • Fixes a 'missed spot' from Netcdf separate loadsave #4803
  • [Hopefully] enables manual running of the overnight benchmark GHA, starting from a custom commit.

Consult Iris pull request check list

stephenworsley
stephenworsley approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@stephenworsley stephenworsley merged commit da03d73 into SciTools:main Sep 29, 2022
@trexfeathers trexfeathers mentioned this pull request Sep 29, 2022
Merged
@trexfeathers
Copy link
Contributor Author

Thanks @stephenworsley! This did indeed enabling manual running of the action. Shame I messed up (#5005).

@trexfeathers trexfeathers deleted the bm_fixes branch October 12, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenworsley stephenworsley stephenworsley approved these changes

@pp-mo pp-mo Awaiting requested review from pp-mo

Assignees
No one assigned
Labels
Type: Performance Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trexfeathers @stephenworsley